media/blink/multibuffer_data_source_unittest.cc - Issue 2516353002: Introduce url_list to the Response scheme of CacheStorage.

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 2516353002: Introduce url_list to the Response scheme of CacheStorage. (Closed)

Patch Set: incorporated falken's comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« content/renderer/service_worker/service_worker_context_client.cc ('K') | « content/renderer/service_worker/service_worker_type_util.cc ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | third_party/WebKit/Source/platform/network/ResourceResponse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/blink/multibuffer_data_source_unittest.cc

diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc

index ea90482591765fcf53aa27dda70fe380d0575185..f67faaa6a8aa81ae39528cdf967be1109b7e1d25 100644

--- a/media/blink/multibuffer_data_source_unittest.cc

+++ b/media/blink/multibuffer_data_source_unittest.cc

@@ -770,7 +770,8 @@ TEST_F(MultibufferDataSourceTest,

WebURLResponse response1 =

response_generator_->GeneratePartial206(0, kDataSize - 1);

response1.setWasFetchedViaServiceWorker(true);

- response1.setOriginalURLViaServiceWorker(GURL(kHttpUrl));

+ std::vector<blink::WebURL> url_list = {GURL(kHttpUrl)};

+ response1.setURLListViaServiceWorker(url_list);

WebURLResponse response2 =

response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);

// The origin URL of response1 and response2 are same. So no error should

@@ -784,7 +785,8 @@ TEST_F(MultibufferDataSourceTest,

WebURLResponse response1 =

response_generator_->GeneratePartial206(0, kDataSize - 1);

response1.setWasFetchedViaServiceWorker(true);

- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentPathUrl));

+ std::vector<blink::WebURL> url_list = {GURL(kHttpDifferentPathUrl)};

+ response1.setURLListViaServiceWorker(url_list);

WebURLResponse response2 =

response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);

// The origin URL of response1 and response2 are same. So no error should

@@ -798,7 +800,8 @@ TEST_F(MultibufferDataSourceTest,

WebURLResponse response1 =

response_generator_->GeneratePartial206(0, kDataSize - 1);

response1.setWasFetchedViaServiceWorker(true);

- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentOriginUrl));

+ std::vector<blink::WebURL> url_list = {GURL(kHttpDifferentOriginUrl)};

+ response1.setURLListViaServiceWorker(url_list);

WebURLResponse response2 =

response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);

// The origin URL of response1 and response2 are different. So an error should

@@ -812,7 +815,8 @@ TEST_F(MultibufferDataSourceTest,

WebURLResponse response1 =

response_generator_->GeneratePartial206(0, kDataSize - 1);

response1.setWasFetchedViaServiceWorker(true);

- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentOriginUrl));

+ std::vector<blink::WebURL> url_list = {GURL(kHttpDifferentOriginUrl)};

+ response1.setURLListViaServiceWorker(url_list);

WebURLResponse response2 =

response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);

// The origin URL of response1 and response2 are different, but a CORS check

@@ -1505,7 +1509,9 @@ TEST_F(MultibufferDataSourceTest, DidPassCORSAccessTest) {

WebURLResponse response1 =

response_generator_->GeneratePartial206(0, kDataSize - 1);

response1.setWasFetchedViaServiceWorker(true);

- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentOriginUrl));

+ std::vector<blink::WebURL> urlList;

+ urlList.push_back(GURL(kHttpDifferentOriginUrl));

falken 2016/12/05 04:32:42 nit: url_list. also urlList = {GURL(...)} for cons

horo 2016/12/05 04:58:32 Done.

+ response1.setURLListViaServiceWorker(urlList);

WebURLResponse response2 =

response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);