Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 2516353002: Introduce url_list to the Response scheme of CacheStorage. (Closed)
Patch Set: incorporated falken's comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/multibuffer_data_source_unittest.cc
diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc
index ea90482591765fcf53aa27dda70fe380d0575185..c06c467e812898bf317d6cdd63ad11ed6937770a 100644
--- a/media/blink/multibuffer_data_source_unittest.cc
+++ b/media/blink/multibuffer_data_source_unittest.cc
@@ -770,7 +770,9 @@ TEST_F(MultibufferDataSourceTest,
WebURLResponse response1 =
response_generator_->GeneratePartial206(0, kDataSize - 1);
response1.setWasFetchedViaServiceWorker(true);
- response1.setOriginalURLViaServiceWorker(GURL(kHttpUrl));
+ std::vector<blink::WebURL> urlList;
falken 2016/12/05 01:22:33 url_list (throughout this file) Optional suggesti
horo 2016/12/05 03:39:49 Done.
+ urlList.push_back(GURL(kHttpUrl));
+ response1.setURLListViaServiceWorker(urlList);
WebURLResponse response2 =
response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);
// The origin URL of response1 and response2 are same. So no error should
@@ -784,7 +786,9 @@ TEST_F(MultibufferDataSourceTest,
WebURLResponse response1 =
response_generator_->GeneratePartial206(0, kDataSize - 1);
response1.setWasFetchedViaServiceWorker(true);
- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentPathUrl));
+ std::vector<blink::WebURL> urlList;
+ urlList.push_back(GURL(kHttpDifferentPathUrl));
+ response1.setURLListViaServiceWorker(urlList);
WebURLResponse response2 =
response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);
// The origin URL of response1 and response2 are same. So no error should
@@ -798,7 +802,9 @@ TEST_F(MultibufferDataSourceTest,
WebURLResponse response1 =
response_generator_->GeneratePartial206(0, kDataSize - 1);
response1.setWasFetchedViaServiceWorker(true);
- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentOriginUrl));
+ std::vector<blink::WebURL> urlList;
+ urlList.push_back(GURL(kHttpDifferentOriginUrl));
+ response1.setURLListViaServiceWorker(urlList);
WebURLResponse response2 =
response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);
// The origin URL of response1 and response2 are different. So an error should
@@ -812,7 +818,9 @@ TEST_F(MultibufferDataSourceTest,
WebURLResponse response1 =
response_generator_->GeneratePartial206(0, kDataSize - 1);
response1.setWasFetchedViaServiceWorker(true);
- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentOriginUrl));
+ std::vector<blink::WebURL> urlList;
+ urlList.push_back(GURL(kHttpDifferentOriginUrl));
+ response1.setURLListViaServiceWorker(urlList);
WebURLResponse response2 =
response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);
// The origin URL of response1 and response2 are different, but a CORS check
@@ -1505,7 +1513,9 @@ TEST_F(MultibufferDataSourceTest, DidPassCORSAccessTest) {
WebURLResponse response1 =
response_generator_->GeneratePartial206(0, kDataSize - 1);
response1.setWasFetchedViaServiceWorker(true);
- response1.setOriginalURLViaServiceWorker(GURL(kHttpDifferentOriginUrl));
+ std::vector<blink::WebURL> urlList;
+ urlList.push_back(GURL(kHttpDifferentOriginUrl));
+ response1.setURLListViaServiceWorker(urlList);
WebURLResponse response2 =
response_generator_->GeneratePartial206(kDataSize, kDataSize * 2 - 1);

Powered by Google App Engine
This is Rietveld 408576698