Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2516343002: Fix Jessie sysroot missing deps (Closed)

Created:
4 years, 1 month ago by lmilko
Modified:
4 years ago
CC:
chromium-reviews, petar.jovanovic, gordana.cmiljanovic_imgtec.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Jessie sysroot missing deps Adding dependencies needed by libgtk3. BUG=132847 TEST=Run GN gen TBR=thestig@chromium.org Committed: https://crrev.com/5735a5e9605d549acb6495e1fb65384a54fe0a48 Cr-Commit-Position: refs/heads/master@{#433712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 2 chunks +6 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 2 chunks +6 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm64 View 2 chunks +6 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 2 chunks +6 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 2 chunks +6 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
lmilko
Change https://chromiumcodereview.appspot.com/2444473002 added libgtk3 and in Jessie this introduced dependencies for libxkbcommon, libatk-bridge and libatspi. ...
4 years, 1 month ago (2016-11-21 10:39:46 UTC) #3
Tom (Use chromium acct)
lgtm If you like, once this lands I can upload the new sysroots on your ...
4 years, 1 month ago (2016-11-21 16:41:13 UTC) #4
Sam Clegg
lgtm
4 years, 1 month ago (2016-11-21 18:12:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516343002/1
4 years, 1 month ago (2016-11-21 20:38:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/309748)
4 years, 1 month ago (2016-11-21 20:46:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516343002/1
4 years, 1 month ago (2016-11-22 00:08:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 00:20:53 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5735a5e9605d549acb6495e1fb65384a54fe0a48 Cr-Commit-Position: refs/heads/master@{#433712}
4 years, 1 month ago (2016-11-22 00:27:34 UTC) #17
lmilko
On 2016/11/21 16:41:13, Tom Anderson wrote: > lgtm > > If you like, once this ...
4 years, 1 month ago (2016-11-22 08:01:55 UTC) #18
Lei Zhang
4 years ago (2016-11-29 04:00:07 UTC) #20
Message was sent while issue was closed.
lgtm

Please remember to CC those you TBR.

Powered by Google App Engine
This is Rietveld 408576698