Chromium Code Reviews Chromium Code Reviews
Issue 251633002:
Add support for DocumentFragment.getElementById() (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/dom/DocumentFragment/get-element-by-id.html |
| diff --git a/LayoutTests/fast/dom/DocumentFragment/get-element-by-id.html b/LayoutTests/fast/dom/DocumentFragment/get-element-by-id.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a8987373ce991ccf0643fe3bb3399c1475de0f51 |
| --- /dev/null |
| +++ b/LayoutTests/fast/dom/DocumentFragment/get-element-by-id.html |
| @@ -0,0 +1,40 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| +<link rel="help" href="http://dom.spec.whatwg.org/#interface-nonelementparentnode"> |
| +<script src="../../../resources/js-test.js"></script> |
| +</head> |
| +<body> |
| +<div id="notInFragment"></div> |
| +<div id="duplicateId1"></div> |
| +<script> |
| +description("Tests that getElementById() API is exposed on DocumentFragment nodes."); |
| + |
| +var fragment = new DocumentFragment(); |
| +var div = document.createElement("div", ""); |
| +div.id = "divID"; |
| +fragment.appendChild(div); |
| +var a = document.createElement("a", ""); |
| +a.id = "aID"; |
| +div.appendChild(a); |
| +var span = document.createElement("span", ""); |
|
arv (Not doing code reviews)
2014/04/28 18:44:27
Why the second argument?
Inactive
2014/04/28 18:46:17
That's a good question :) I'll fix this now.
Inactive
2014/04/28 18:50:48
Done.
|
| +span.id = "duplicateId1"; |
| +div.appendChild(span); |
| +var h1 = document.createElement("h1", ""); |
| +h1.id = "duplicateId2"; |
| +div.appendChild(h1); |
| +var h2 = document.createElement("h2", ""); |
| +h2.id = "duplicateId2"; |
| +div.appendChild(h2); |
| + |
| +shouldBe("fragment.getElementById('divID')", "div"); |
| +shouldBe("fragment.getElementById('aID')", "a"); |
| +shouldBeNull("fragment.getElementById('notInFragment')"); |
| +shouldBeNull("fragment.getElementById('doesNotExist')"); |
| + |
| +// Duplicate ID cases. |
| +shouldBe("fragment.getElementById('duplicateId1')", "span"); // Should return the Element *inside* the DocumentFragment. |
| +shouldBe("fragment.getElementById('duplicateId2')", "h1"); // Should return the first matching Element in case of duplicate. |
| +</script> |
| +</body> |
| +</html> |
