LayoutTests/fast/dom/DocumentFragment/get-element-by-id.html - Issue 251633002: Add support for DocumentFragment.getElementById()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/DocumentFragment/get-element-by-id.html

Issue 251633002: Add support for DocumentFragment.getElementById() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use isInTreeScope() instead of isInDocument() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link rel="help" href="http://dom.spec.whatwg.org/#interface-nonelementparentnod e">

	5 <script src="../../../resources/js-test.js"></script>

	6 </head>

	7 <body>

	8 <div id="notInFragment"></div>

	9 <script>

	10 description("Tests that getElementById() API is exposed on DocumentFragment node s.");

	11

	12 var fragment = new DocumentFragment();

	13 var div = document.createElement("div", "");

	14 div.id = "divID";

	15 fragment.appendChild(div);

	16 var a = document.createElement("a", "");

	17 a.id = "aID";

	18 div.appendChild(a);

	19

	20 shouldBe("fragment.getElementById('divID')", "div");

	21 shouldBe("fragment.getElementById('aID')", "a");

	22 shouldBeNull("fragment.getElementById('notInFragment')");

	23 shouldBeNull("fragment.getElementById('doesNotExist')");
	abarth-chromium 2014/04/28 18:25:25 Does this test all the paths through the code you' Does this test all the paths through the code you've added? For example, does it test the path where there are two elements with the ID, one inside the ContainerNode and one outside that's found by the implementation in the treescope? Inactive 2014/04/28 18:31:49 No, I will improve the test to cover the duplicate Show quoted text On 2014/04/28 18:25:25, abarth wrote: > Does this test all the paths through the code you've added? For example, does > it test the path where there are two elements with the ID, one inside the > ContainerNode and one outside that's found by the implementation in the > treescope? No, I will improve the test to cover the duplicate id cases. Inactive 2014/04/28 18:42:02 Done. Show quoted text On 2014/04/28 18:25:25, abarth wrote: > Does this test all the paths through the code you've added? For example, does > it test the path where there are two elements with the ID, one inside the > ContainerNode and one outside that's found by the implementation in the > treescope? Done.
	24 </script>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/DocumentFragment/get-element-by-id-expected.txt » ('j') | Source/core/dom/ContainerNode.cpp » ('J')