[heap] Refactor heap object iteration

[heap] Refactor heap object iteration

BUG=

Committed: https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76
Cr-Commit-Position: refs/heads/master@{#41226}

[Michael Lippautz, 2016-11-22 13:18:32]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-11-22 13:18:32]

ptal

[Michael Lippautz, 2016-11-22 13:18:36]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 13:18:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 13:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 13:21:36]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16635)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16595)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/18196)

[Michael Lippautz, 2016-11-22 14:05:07]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 14:05:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 14:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 14:41:28]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16692)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Michael Lippautz, 2016-11-22 15:55:03]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:55:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 16:18:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 16:18:51]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16710)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Michael Lippautz, 2016-11-22 16:54:24]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 16:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 17:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 17:18:28]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16711)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Michael Lippautz, 2016-11-22 18:09:25]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 18:09:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:55:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:55:13]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-11-23 13:07:26]

LGTM

https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):

https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h#n...
src/heap/spaces-inl.h:74: while (cur_addr_ != cur_end_) {
Please add a comment here.

[Michael Lippautz, 2016-11-23 13:29:07]

https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):

https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h#n...
src/heap/spaces-inl.h:74: while (cur_addr_ != cur_end_) {
On 2016/11/23 13:07:26, Hannes Payer wrote:
> Please add a comment here.

Done.

[Michael Lippautz, 2016-11-23 13:29:10]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-11-23 13:29:11]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2516303006/#ps100001
(title: "Add comment")

[commit-bot: I haz the power, 2016-11-23 13:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:57:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479907750725130,
"parent_rev": "e567289ecefbfab0015d29de4fbbd1b3720815d8", "commit_rev":
"f69a076fd7ed9ed543fc70e6d37110811182a87b"}

[commit-bot: I haz the power, 2016-11-23 13:57:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-23 13:58:22]

Description was changed from

==========
[heap] Refactor heap object iteration

BUG=
==========

to

==========
[heap] Refactor heap object iteration

BUG=

Committed: https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76
Cr-Commit-Position: refs/heads/master@{#41226}
==========

[commit-bot: I haz the power, 2016-11-23 13:58:23]

Patchset 6 (id:??) landed as
https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76
Cr-Commit-Position: refs/heads/master@{#41226}

[Michael Achenbach, 2016-11-23 15:28:03]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2529663002/ by machenbach@chromium.org.

The reason for reverting is: Breaks msan:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20....

[Michael Achenbach, 2016-11-23 15:30:43]

Also getting this:
07:23:52.461 32510   # Fatal error in ../../v8/src/heap/marking.h, line 340
07:23:52.461 32510   # Check failed: IsGrey(markbit).

In
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%...