Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Michael Lippautz Modified:
4 years ago Reviewers:
Hannes Payer (out of office) CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Refactor heap object iteration
BUG=
Committed: https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76
Cr-Commit-Position: refs/heads/master@{#41226}
Patch Set 1 #Patch Set 2 : Fix compilation #Patch Set 3 : Fix remaining issue #Patch Set 4 : Actually fixing the issue #Patch Set 5 : Final fix #
Total comments: 2
Patch Set 6 : Add comment #
Created: 4 years ago
Messages
Total messages: 33 (25 generated)
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
ptal
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16635) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16595) v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/18196)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16692) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16710) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16711) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h File src/heap/spaces-inl.h (right): https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h#n... src/heap/spaces-inl.h:74: while (cur_addr_ != cur_end_) { Please add a comment here.
https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h File src/heap/spaces-inl.h (right): https://codereview.chromium.org/2516303006/diff/80001/src/heap/spaces-inl.h#n... src/heap/spaces-inl.h:74: while (cur_addr_ != cur_end_) { On 2016/11/23 13:07:26, Hannes Payer wrote: > Please add a comment here. Done.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/2516303006/#ps100001 (title: "Add comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479907750725130,
"parent_rev": "e567289ecefbfab0015d29de4fbbd1b3720815d8", "commit_rev":
"f69a076fd7ed9ed543fc70e6d37110811182a87b"}
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Refactor heap object iteration BUG= ========== to ========== [heap] Refactor heap object iteration BUG= Committed: https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76 Cr-Commit-Position: refs/heads/master@{#41226} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76 Cr-Commit-Position: refs/heads/master@{#41226}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2529663002/ by machenbach@chromium.org. The reason for reverting is: Breaks msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20....
Message was sent while issue was closed.
Also getting this: 07:23:52.461 32510 # Fatal error in ../../v8/src/heap/marking.h, line 340 07:23:52.461 32510 # Check failed: IsGrey(markbit). In https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
