Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2516263002: Changed ETextTransform to an enum class and renamed its members (Closed)

Created:
4 years, 1 month ago by sashab
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10, dcheng
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed ETextTransform to an enum class and renamed its members Changed ETextTransform to an enum class and gave it an unsigned underlying type. Also renamed its members to match its keywords from CSSValueKeywords.in. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to move ETextTransform to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/24335db82807d6544f5c3e3f8ae01c6796ca16c9 Cr-Commit-Position: refs/heads/master@{#433758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
sashab
Thanks eddy :)
4 years, 1 month ago (2016-11-21 04:45:37 UTC) #3
meade_UTC10
lgtm
4 years, 1 month ago (2016-11-21 05:17:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516263002/1
4 years, 1 month ago (2016-11-21 05:40:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/309226)
4 years, 1 month ago (2016-11-21 05:46:40 UTC) #10
sashab
dcheng@ please RS web/ :)
4 years, 1 month ago (2016-11-22 02:39:15 UTC) #12
dcheng
rs lgtm
4 years, 1 month ago (2016-11-22 02:44:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516263002/1
4 years, 1 month ago (2016-11-22 02:47:00 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 02:56:25 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:59:22 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24335db82807d6544f5c3e3f8ae01c6796ca16c9
Cr-Commit-Position: refs/heads/master@{#433758}

Powered by Google App Engine
This is Rietveld 408576698