Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2516253002: [DevTools] Remove HandlerRegistry. (Closed)
Patch Set: rebase, fixed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
index 7ddc91606980625703978970a7cc1f8d4f4be5d8..4d930b6397eb47ca2ebc18ab0a8470410ce590d9 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
@@ -388,22 +388,14 @@ Extensions.ExtensionServer = class extends Common.Object {
_onSetOpenResourceHandler(message, port) {
var name = this._registeredExtensions[port._extensionOrigin].name || ('Extension ' + port._extensionOrigin);
if (message.handlerPresent)
- Components.openAnchorLocationRegistry.registerHandler(name, this._handleOpenURL.bind(this, port));
+ Components.Linkifier.registerLinkHandler(name, this._handleOpenURL.bind(this, port));
else
- Components.openAnchorLocationRegistry.unregisterHandler(name);
+ Components.Linkifier.unregisterLinkHandler(name);
}
- _handleOpenURL(port, details) {
- var url = /** @type {string} */ (details.url);
- var contentProvider = Workspace.workspace.uiSourceCodeForURL(url) || Bindings.resourceForURL(url);
- if (!contentProvider)
- return false;
-
- var lineNumber = details.lineNumber;
- if (typeof lineNumber === 'number')
- lineNumber += 1;
- port.postMessage({command: 'open-resource', resource: this._makeResource(contentProvider), lineNumber: lineNumber});
- return true;
+ _handleOpenURL(port, contentProvider, lineNumber) {
+ port.postMessage(
+ {command: 'open-resource', resource: this._makeResource(contentProvider), lineNumber: lineNumber + 1});
}
_onReload(message) {

Powered by Google App Engine
This is Rietveld 408576698