Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2516163002: Remove redundant signals_check_notifier_ schedule. (Closed)

Created:
4 years, 1 month ago by Yupei Wang
Modified:
4 years ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/6182cb1b36dacbcb4cfef9ecb77fe1ee9dbd07b5 Cr-Commit-Position: refs/heads/master@{#434105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M cc/tiles/tile_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Yupei Wang
4 years, 1 month ago (2016-11-20 08:31:44 UTC) #4
Yupei Wang
4 years, 1 month ago (2016-11-20 11:00:00 UTC) #5
Yupei Wang
4 years, 1 month ago (2016-11-21 02:13:05 UTC) #6
Yupei Wang
4 years, 1 month ago (2016-11-22 00:16:25 UTC) #7
Yupei Wang
Hi vmpstr, I remove redundant signals_check_notifier_ schedule, and add a comment above signals_.ready_to_activate = need_to_signal_activate ...
4 years, 1 month ago (2016-11-22 02:03:07 UTC) #8
vmpstr
lgtm, thanks!
4 years ago (2016-11-22 18:01:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516163002/1
4 years ago (2016-11-23 03:11:25 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 03:45:28 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-23 03:47:42 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6182cb1b36dacbcb4cfef9ecb77fe1ee9dbd07b5
Cr-Commit-Position: refs/heads/master@{#434105}

Powered by Google App Engine
This is Rietveld 408576698