|
|
Created:
4 years, 1 month ago by Yupei Wang Modified:
4 years ago Reviewers:
vmpstr CC:
chromium-reviews, cc-bugs_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove redundant signals_check_notifier_ schedule.
signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/6182cb1b36dacbcb4cfef9ecb77fe1ee9dbd07b5
Cr-Commit-Position: refs/heads/master@{#434105}
Patch Set 1 #
Messages
Total messages: 24 (15 generated)
Description was changed from ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. ========== to ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Description was changed from ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
perryuwang@tencent.com changed reviewers: + vmpstr@chromium.org
Hi vmpstr, I remove redundant signals_check_notifier_ schedule, and add a comment above signals_.ready_to_activate = need_to_signal_activate stating that the signals notifier is already scheduled above in the same function. Can you review this code, please?
The CQ bit was checked by perryuwang@tencent.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm, thanks!
The CQ bit was checked by perryuwang@tencent.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by perryuwang@tencent.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1479870668440830, "parent_rev": "fe8017ac208d8109b3aacfd58df0bd134865db8c", "commit_rev": "eb4ca6a2011aa3196f40407949aec0ace9fca3cc"}
Message was sent while issue was closed.
Description was changed from ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove redundant signals_check_notifier_ schedule. signals_check_notifier_ is scheduled twice in function CheckIfMoreTilesNeedToBePrepared. it's redundant and remove it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/6182cb1b36dacbcb4cfef9ecb77fe1ee9dbd07b5 Cr-Commit-Position: refs/heads/master@{#434105} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6182cb1b36dacbcb4cfef9ecb77fe1ee9dbd07b5 Cr-Commit-Position: refs/heads/master@{#434105} |