Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2516133003: Unsupress Test_DateField_locale_zh_HK.pdf on Linux. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Unsupress Test_DateField_locale_zh_HK.pdf on Linux. It passes on Linux bots. Committed: https://pdfium.googlesource.com/pdfium/+/80b7608c66028ef34df865e5313fae1f028d4262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/SUPPRESSIONS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Lei Zhang
4 years, 1 month ago (2016-11-20 07:16:35 UTC) #4
dsinclair
lgtm
4 years, 1 month ago (2016-11-21 13:56:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516133003/1
4 years, 1 month ago (2016-11-21 13:56:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/80b7608c66028ef34df865e5313fae1f028d4262
4 years, 1 month ago (2016-11-21 14:11:04 UTC) #12
Lei Zhang
Uh, this CL is based purely on looking at corpus test results from trybots and ...
4 years, 1 month ago (2016-11-21 23:34:30 UTC) #13
Lei Zhang
4 years, 1 month ago (2016-11-22 00:13:25 UTC) #14
Message was sent while issue was closed.
On 2016/11/21 23:34:30, Lei Zhang (Mostly OOO) wrote:
> Uh, this CL is based purely on looking at corpus test results from trybots and
> the waterfall. All the bots there are green of course, but my local build
fails.
> That might explain why this was surpressed in the first place. I'll look and
see
> why it's failing locally.

I had ttf-kochi-gothic and ttf-kochi-mincho installed locally. Per
https://crbug.com/665515, those are (being) deprecated, so I removed them
locally and now my local corpus test passes.

Powered by Google App Engine
This is Rietveld 408576698