Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2515993002: Replace DOMWindow with iframe attrs: src, id, name (Closed)
Patch Set: don't truncate ID Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
index 2ea1b664788ccbc49b6f1201a02c665833156a4e..4ceca4b0f8d38eeedbbc4b9429efb91be3892227 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
@@ -92,7 +92,8 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
initialize(scope.getScriptState());
// Add a long task entry, but no observer registered.
- m_base->addLongTaskTiming(1234, 5678, "www.foo.com/bar", nullptr);
+ m_base->addLongTaskTiming(1234, 5678, "same-origin", "www.foo.com/bar", "",
+ "");
EXPECT_FALSE(m_base->hasPerformanceObserverFor(PerformanceEntry::LongTask));
EXPECT_EQ(0, numPerformanceEntriesInObserver()); // has no effect
@@ -106,7 +107,8 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
EXPECT_TRUE(m_base->hasPerformanceObserverFor(PerformanceEntry::LongTask));
// Add a long task entry
- m_base->addLongTaskTiming(1234, 5678, "www.foo.com/bar", nullptr);
+ m_base->addLongTaskTiming(1234, 5678, "same-origin", "www.foo.com/bar", "",
+ "");
EXPECT_EQ(1, numPerformanceEntriesInObserver()); // added an entry
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698