Replace DOMWindow with iframe attrs: src, id, name

Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG=667007
Committed: https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856
Cr-Commit-Position: refs/heads/master@{#433779}

[panicker, 2016-11-19 02:00:53]

panicker@chromium.org changed reviewers:
+ caseq@chromium.org

[panicker, 2016-11-19 02:00:54]

PTAL.

[panicker, 2016-11-21 19:39:09]

panicker@chromium.org changed reviewers:
+ skobes@chromium.org

[panicker, 2016-11-21 19:39:09]

Steve, mind reviewing for OWNERs?
This is similar to the previous CL you reviewed:
https://codereview.chromium.org/2381163003/
We have now converged on showing the specific iframe attributes as opposed to
DomWindow.

[skobes, 2016-11-22 00:21:25]

Change description should mention that this is for the Long Tasks API (not a
change to DOMWindow itself).

https://codereview.chromium.org/2515993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2515993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:213: std::tuple<String,
String, String> Performance::culpritFrameAttributes(
It seems unnecessary to wrap these in a std::tuple only to unwrap them
immediately.  Could you just inline the getFrameAttribute(...) calls into the
line that calls addLongTaskTiming?

[panicker, 2016-11-22 00:28:09]

Description was changed from

==========
Replace DOMWindow with iframe attrs: src, id, name

BUG=667007
==========

to

==========
Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG=667007
==========

[panicker, 2016-11-22 00:39:47]

PTAL

https://codereview.chromium.org/2515993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2515993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:213: std::tuple<String,
String, String> Performance::culpritFrameAttributes(
On 2016/11/22 00:21:25, skobes wrote:
> It seems unnecessary to wrap these in a std::tuple only to unwrap them
> immediately.  Could you just inline the getFrameAttribute(...) calls into the
> line that calls addLongTaskTiming?

Agreed. Done.

[skobes, 2016-11-22 00:42:39]

lgtm

https://codereview.chromium.org/2515993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2515993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:46: #include <tuple>
You can remove this now.

[panicker, 2016-11-22 00:45:09]

https://codereview.chromium.org/2515993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2515993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:46: #include <tuple>
On 2016/11/22 00:42:39, skobes wrote:
> You can remove this now.

Done.

[panicker, 2016-11-22 00:45:26]

The CQ bit was checked by panicker@chromium.org

[panicker, 2016-11-22 00:45:26]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2515993002/#ps80001
(title: "remove unnecessary include")

[commit-bot: I haz the power, 2016-11-22 00:46:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2016-11-22 00:56:56]

lgtm

https://codereview.chromium.org/2515993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2515993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:226:
getFrameAttribute(frameOwner, HTMLNames::idAttr, true),
nit: I think it generally doesn't make sense to truncate id either.

[panicker, 2016-11-22 01:00:14]

The CQ bit was unchecked by panicker@chromium.org

[panicker, 2016-11-22 01:01:10]

https://codereview.chromium.org/2515993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2515993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:226:
getFrameAttribute(frameOwner, HTMLNames::idAttr, true),
On 2016/11/22 00:56:56, caseq wrote:
> nit: I think it generally doesn't make sense to truncate id either.

Done.

[panicker, 2016-11-22 01:02:11]

The CQ bit was checked by panicker@chromium.org

[panicker, 2016-11-22 01:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org,
skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2515993002/#ps100001
(title: "don't truncate ID")

[commit-bot: I haz the power, 2016-11-22 01:02:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 01:22:40]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[panicker, 2016-11-22 01:58:53]

The CQ bit was checked by panicker@chromium.org

[commit-bot: I haz the power, 2016-11-22 01:59:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:48:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479779933516720,
"parent_rev": "2529ec24263adbbb04665dd3e16eabfbf47e713a", "commit_rev":
"7483e728a5f25a411f8a7d53b560cc667e251f27"}

[commit-bot: I haz the power, 2016-11-22 03:49:08]

Description was changed from

==========
Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG=667007
==========

to

==========
Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG=667007
==========

[commit-bot: I haz the power, 2016-11-22 03:49:08]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-22 03:52:20]

Description was changed from

==========
Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG=667007
==========

to

==========
Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG=667007

Committed: https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856
Cr-Commit-Position: refs/heads/master@{#433779}
==========

[commit-bot: I haz the power, 2016-11-22 03:52:21]

Patchset 6 (id:??) landed as
https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856
Cr-Commit-Position: refs/heads/master@{#433779}