Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 251593011: Make caps lock light to a square in upper corner. (Closed)

Created:
6 years, 7 months ago by rsadam
Modified:
6 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

The new spec for the keyboard shift-light is a square in the upper left corner. Changing this to be consistent with the IME keyboard. BUG=364468 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267055

Patch Set 1 #

Patch Set 2 : Change color. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/keyboard/resources/elements/kb-shift-key.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/keyboard/resources/main.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
rsadam
PTAL Biao!
6 years, 7 months ago (2014-04-28 16:52:51 UTC) #1
bshe
On 2014/04/28 16:52:51, rsadam wrote: > PTAL Biao! lgtm
6 years, 7 months ago (2014-04-29 15:57:18 UTC) #2
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-04-29 15:57:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/251593011/20001
6 years, 7 months ago (2014-04-29 15:58:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:56:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:56:43 UTC) #6
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-04-29 23:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/251593011/20001
6 years, 7 months ago (2014-04-29 23:13:27 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:06:07 UTC) #9
Message was sent while issue was closed.
Change committed as 267055

Powered by Google App Engine
This is Rietveld 408576698