Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 251593008: Don't include abort() cost when timing MSE methods. (Closed)

Created:
6 years, 8 months ago by DaleCurtis
Modified:
6 years, 8 months ago
Reviewers:
tonyg, shadi
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Don't include abort() cost when timing MSE methods. xhr.abort() and sourceBuffer.abort() were transitively included via onPlaybackStarted(). It's not relevant to the recorded metrics so measure end time before the onPlaybackStarted() calls. BUG=367228 TEST=ran telemetry tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/perf/page_sets/mse_cases/startup_test.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
DaleCurtis
6 years, 8 months ago (2014-04-25 20:31:54 UTC) #1
shadi
LGTM nit: can you specify xhr.abort() in CL description? Without looking into code, it can ...
6 years, 8 months ago (2014-04-25 21:00:19 UTC) #2
DaleCurtis
Done! Thanks.
6 years, 8 months ago (2014-04-25 21:10:29 UTC) #3
tonyg
lgtm2
6 years, 8 months ago (2014-04-25 21:33:13 UTC) #4
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-25 21:37:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251593008/1
6 years, 8 months ago (2014-04-25 21:59:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:29:14 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-26 06:29:15 UTC) #8
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 13:21:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251593008/1
6 years, 8 months ago (2014-04-26 13:21:25 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 22:08:11 UTC) #11
Message was sent while issue was closed.
Change committed as 266378

Powered by Google App Engine
This is Rietveld 408576698