Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251593004: Remove SW rendering path code from BrowserPlugin. (Closed)

Created:
6 years, 8 months ago by lazyboy
Modified:
6 years, 7 months ago
Reviewers:
Fady Samuel, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, kenrb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove SW rendering path code from BrowserPlugin. BUG=364560 Test=This changes the internals of rendering <webview> in chrome-apps. No noticeable changes should be observed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266797

Patch Set 1 #

Patch Set 2 : this compiles and renders, wheee #

Patch Set 3 : update-2 #

Patch Set 4 : tests pass now #

Patch Set 5 : almost r #

Patch Set 6 : done #

Patch Set 7 : rebase #

Patch Set 8 : rebase after test file change commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -687 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 2 3 4 5 12 chunks +8 lines, -46 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 4 5 13 chunks +6 lines, -62 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/browser_plugin/test_browser_plugin_guest.h View 1 2 5 chunks +8 lines, -12 lines 0 comments Download
M content/browser/browser_plugin/test_browser_plugin_guest.cc View 1 2 3 4 5 6 7 5 chunks +25 lines, -31 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -5 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 2 3 4 5 5 chunks +0 lines, -44 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 2 3 4 5 6 7 6 chunks +2 lines, -28 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 4 5 6 7 17 chunks +32 lines, -224 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_backing_store.h View 1 1 chunk +0 lines, -66 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_backing_store.cc View 1 1 chunk +0 lines, -99 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 2 3 4 8 chunks +10 lines, -60 lines 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
lazyboy
6 years, 8 months ago (2014-04-25 23:33:17 UTC) #1
Fady Samuel
Wow, huge reduction in complexity! LGTM!
6 years, 7 months ago (2014-04-28 19:35:56 UTC) #2
lazyboy
+nasko@ for OWNERS review of: content/browser/frame_host/render_widget_host_view_guest.cc content/common/browser_plugin/browser_plugin_messages.h
6 years, 7 months ago (2014-04-28 20:28:46 UTC) #3
lazyboy
+nasko@ for OWNERS review of: content/browser/frame_host/render_widget_host_view_guest.cc content/common/browser_plugin/browser_plugin_messages.h
6 years, 7 months ago (2014-04-28 20:28:54 UTC) #4
lazyboy
+jam FYI.
6 years, 7 months ago (2014-04-28 20:34:33 UTC) #5
nasko
I am not as familiar with the graphics stack, so it is better for someone ...
6 years, 7 months ago (2014-04-28 20:36:46 UTC) #6
Fady Samuel
On 2014/04/28 20:36:46, nasko wrote: > I am not as familiar with the graphics stack, ...
6 years, 7 months ago (2014-04-28 20:38:05 UTC) #7
nasko
Adding kenrb@ to cc, since he might be interested in such changes. Rubberstamp LGTM.
6 years, 7 months ago (2014-04-28 20:45:41 UTC) #8
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-04-28 22:50:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/251593004/140001
6 years, 7 months ago (2014-04-28 22:51:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:54:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 22:54:47 UTC) #12
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-04-29 00:39:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/251593004/140001
6 years, 7 months ago (2014-04-29 00:40:31 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 09:13:05 UTC) #15
Message was sent while issue was closed. 
Change committed as 266797

Powered by Google App Engine
This is Rietveld 408576698