chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java - Issue 2515853002: [Payments] Fix new billing address label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

Issue 2515853002: [Payments] Fix new billing address label. (Closed)

Patch Set: Updated test and code added in the Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java ('k') | chrome/browser/autofill/android/personal_data_manager_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

index 7b5fedb1f9555676f013bbd7a30253b2043bd95a..7fbdcd87d26f3d46814eab72aa4acda46916ccad 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

@@ -165,10 +165,9 @@ public class PaymentRequestBillingAddressTest extends PaymentRequestTestBase {

// option to add a new address.

assertEquals(5, getSpinnerItemCountInCardEditor(BILLING_ADDRESS_DROPDOWN_INDEX));

- // TODO(crbug.com/666048): New billing address label is wrong.

// The fist suggestion should be the newly added address.

assertTrue(getSpinnerTextAtPositionInCardEditor(BILLING_ADDRESS_DROPDOWN_INDEX,

- 0).equals("Google, 340 Main St, Los Angeles, CA 90291, United States"));

+ 0).equals("Seb Doe, 340 Main St, Los Angeles, CA 90291"));

// The rest of the billing address suggestions should be ordered by frecency.

assertTrue(getSpinnerTextAtPositionInCardEditor(BILLING_ADDRESS_DROPDOWN_INDEX,

@@ -206,9 +205,8 @@ public class PaymentRequestBillingAddressTest extends PaymentRequestTestBase {

// option to add a new address.

assertEquals(5, getSpinnerItemCountInCardEditor(BILLING_ADDRESS_DROPDOWN_INDEX));

- // TODO(crbug.com/666048): New billing address label is wrong.

// The new address should be suggested first.

assertTrue(getSpinnerTextAtPositionInCardEditor(BILLING_ADDRESS_DROPDOWN_INDEX,

- 0).equals("Google, 340 Main St, Los Angeles, CA 90291, United States"));

+ 0).equals("Seb Doe, 340 Main St, Los Angeles, CA 90291"));

}