chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java - Issue 2515853002: [Payments] Fix new billing address label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

Issue 2515853002: [Payments] Fix new billing address label. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

index 784ec6ff8cd691225b92069a54d4fcfb1dcb623f..a3c31f7573868a52fbe8d4a5639baab575ea8a6e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

@@ -220,8 +220,6 @@ public class AddressEditor extends EditorBase<AutofillAddress> {

// Calculate the label for this profile. The label's format depends on the country and

please use gerrit instead 2016/11/18 21:56:22 Please remove the comment about the label.

sebsg 2016/11/21 16:07:09 Done.

// language code for the profile.

PersonalDataManager pdm = PersonalDataManager.getInstance();

- // TODO(crbug.com/666048): New billing address label is wrong.

- profile.setLabel(pdm.getAddressLabelForPaymentRequest(profile));

// Save the edited autofill profile.

profile.setGUID(pdm.setProfile(profile));

please use gerrit instead 2016/11/18 21:56:22 Since "pdm" is now used only once, you can inline

sebsg 2016/11/21 16:07:09 Done.