Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2515833002: Download or update Mac toolchain for pdfium (Closed)

Created:
4 years, 1 month ago by Wei Li
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Download or update Mac toolchain for pdfium Add Mac toolchain update logic to check whether toolchain should be downloaded. For googlers, it should be downloaded by default. This fix the current sdk directory couldn't be found problem. For googlers who want to opt out of using toolchain, set "use_system_xcode = true" in gn config. Committed: https://pdfium.googlesource.com/pdfium/+/9053f19d78b6215570029d896c1d62bbb0ce5f7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M DEPS View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Wei Li
pls review, thanks
4 years, 1 month ago (2016-11-18 21:24:40 UTC) #7
Lei Zhang
lgtm Works for me.
4 years, 1 month ago (2016-11-18 22:01:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515833002/1
4 years, 1 month ago (2016-11-18 22:03:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 22:03:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/9053f19d78b6215570029d896c1d62bbb0ce...

Powered by Google App Engine
This is Rietveld 408576698