Ensure DiscardPadding is parsed as a signed integer.

Ensure DiscardPadding is parsed as a signed integer.

Per the spec DiscardPadding is a signed integer.  Sadly the parser
only supports UInt values at the moment.  To avoid refactoring the
world, we parse DiscardPadding as binary and have a one off parser.

A re-encoded bear-opus-end-trimming.webm will be landed separately
ahead of this change.

This patch also adds a check to ensure we never parse uint64 values
which will overflow an int64 container.

BUG=366750
TEST=Existing tests pass w/ DCHECK.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266478

[acolwell GONE FROM CHROMIUM, 2014-04-25 00:06:05]

lgtm % comments.

https://codereview.chromium.org/251583003/diff/20001/media/filters/opus_audio...
File media/filters/opus_audio_decoder.cc (right):

https://codereview.chromium.org/251583003/diff/20001/media/filters/opus_audio...
media/filters/opus_audio_decoder.cc:532:
output_timestamp_helper_->AddFrames(frames_decoded);
Shouldn't this be frames_to_output?

https://codereview.chromium.org/251583003/diff/20001/media/filters/opus_audio...
media/filters/opus_audio_decoder.cc:536: *output_buffer = NULL;
Move this above the output_buffer timestamps setup and early return so we aren't
doing throw away work?

[DaleCurtis, 2014-04-25 00:22:10]

Test data landed, will CQ shortly.

https://codereview.chromium.org/251583003/diff/20001/media/filters/opus_audio...
File media/filters/opus_audio_decoder.cc (right):

https://codereview.chromium.org/251583003/diff/20001/media/filters/opus_audio...
media/filters/opus_audio_decoder.cc:532:
output_timestamp_helper_->AddFrames(frames_decoded);
On 2014/04/25 00:06:05, acolwell wrote:
> Shouldn't this be frames_to_output?

Whoops, yes.

https://codereview.chromium.org/251583003/diff/20001/media/filters/opus_audio...
media/filters/opus_audio_decoder.cc:536: *output_buffer = NULL;
On 2014/04/25 00:06:05, acolwell wrote:
> Move this above the output_buffer timestamps setup and early return so we
aren't
> doing throw away work?

Done.

[DaleCurtis, 2014-04-25 01:50:33]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:02:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251583003/40001

[commit-bot: I haz the power, 2014-04-25 02:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:57:49]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[DaleCurtis, 2014-04-25 19:37:06]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-04-25 21:47:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251583003/80001

[commit-bot: I haz the power, 2014-04-25 23:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:11:16]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[DaleCurtis, 2014-04-25 23:12:16]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251583003/80001

[DaleCurtis, 2014-04-25 23:41:56]

The CQ bit was unchecked by dalecurtis@chromium.org

[DaleCurtis, 2014-04-25 23:49:50]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:51:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251583003/100001

[commit-bot: I haz the power, 2014-04-26 08:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 08:44:07]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[DaleCurtis, 2014-04-26 17:27:13]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-04-26 17:28:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251583003/100001

[commit-bot: I haz the power, 2014-04-26 23:31:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 23:31:39]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[DaleCurtis, 2014-04-27 01:14:33]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-04-27 01:15:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251583003/100001

[commit-bot: I haz the power, 2014-04-28 07:56:28]

Change committed as 266478