Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3440)

Unified Diff: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

Issue 2515823002: Remove WebContents::GetRoutingID(). (Closed)
Patch Set: add render_view_host.h include in resource_dispatcher_host_unittest.cc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
index cde562989399e1a5cbb13dff2ccda27a1e7e7b20..a2f943e4c801cb410424d447e87c0e70912f6476 100644
--- a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
@@ -242,12 +242,16 @@ void LaunchURL(
// If the URL is in whitelist, we launch it without asking the user and
// without any additional security checks. Since the URL is whitelisted,
// we assume it can be executed.
+ // TODO(davidsac): External protocol handling needs to be
+ // fixed for OOPIFs. See https://crbug.com/668289.
if (is_whitelisted) {
ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(
- url, render_process_id, web_contents->GetRoutingID());
+ url, render_process_id,
+ web_contents->GetRenderViewHost()->GetRoutingID());
} else {
ExternalProtocolHandler::LaunchUrlWithDelegate(
- url, render_process_id, web_contents->GetRoutingID(), page_transition,
+ url, render_process_id,
+ web_contents->GetRenderViewHost()->GetRoutingID(), page_transition,
has_user_gesture, g_external_protocol_handler_delegate);
}
}

Powered by Google App Engine
This is Rietveld 408576698