Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 2515823002: Remove WebContents::GetRoutingID(). (Closed)
Patch Set: added a TODO for the external protocol bug Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
index 77af2c319ef74b84ccfb2a5ad9962968fff29f58..ac87f3bbfd512a2e870719ca6f121f24326c0cfc 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
@@ -74,6 +74,7 @@
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "google_apis/gaia/oauth2_token_service.h"
@@ -921,7 +922,7 @@ void PrintPreviewHandler::HandlePrint(const base::ListValue* args) {
settings->SetInteger(printing::kPreviewInitiatorHostId,
initiator->GetRenderProcessHost()->GetID());
settings->SetInteger(printing::kPreviewInitiatorRoutingId,
- initiator->GetRoutingID());
+ initiator->GetRenderViewHost()->GetRoutingID());
Lei Zhang 2016/11/24 17:18:26 Uh oh, this is wrong. I have a separate fix: https
}
ClearInitiatorDetails();
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698