Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

Issue 2515823002: Remove WebContents::GetRoutingID(). (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
index ba693e6f91fc8feaaf1c8914aed50b620f2efea5..ecdd71b0ca9e8e5736a3ae5d04cf53d886048778 100644
--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
@@ -16,6 +16,7 @@
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "third_party/WebKit/public/web/WebWindowFeatures.h"
@@ -125,7 +126,8 @@ void PopupBlockerTabHelper::ShowBlockedPopup(int32_t id) {
#endif
if (popup->params.target_contents) {
popup->params.target_contents->Send(new ChromeViewMsg_SetWindowFeatures(
- popup->params.target_contents->GetRoutingID(), popup->window_features));
+ popup->params.target_contents->GetRenderViewHost()->GetRoutingID(),
+ popup->window_features));
}
blocked_popups_.Remove(id);
if (blocked_popups_.IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698