|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Amaury Le Leyzour Modified:
4 years, 1 month ago CC:
chromium-reviews, chromoting-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix remoting_perftests build for ARM
While compiling chromium for chromeos, remoting_perftests fails to
build due to an attempt to return an rvalue
BUG=660541
Committed: https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d
Cr-Commit-Position: refs/heads/master@{#433350}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by cavalcantii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: The author amaury.leleyzour@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by cavalcantii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
cavalcantii@chromium.org changed reviewers: + jamiewalch@chromium.org, sergeyu@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Strange that it fails to compile only for ARM. Do you know why?
I believe the difference from a different behavior between gcc and clang. Chromium for chromiumOS uses gcc, while on Linux it uses clang. As for Intel, I believe it uses clang. No idea for Windows. Gcc seems to be more restrictive (though totally correct) and inflexible when dealing with a std::unique_ptr<A> = std::unique_ptr<B> even when A and B are related. From: sergeyu@chromium.org [mailto:sergeyu@chromium.org] Sent: Friday, November 18, 2016 4:12 PM To: Amaury LeLeyzour; cavalcantii@chromium.org; jamiewalch@chromium.org Cc: chromium-reviews@chromium.org; chromoting-reviews@chromium.org Subject: Re: Fix remoting_perftests build for ARM (issue 2515813002 by amaury.leleyzour@arm.com) LGTM. Strange that it fails to compile only for ARM. Do you know why? https://codereview.chromium.org/2515813002/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Adding it to the CQ.
The CQ bit was checked by cavalcantii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix remoting_perftests build for ARM While compiling chromium for chromeos, remoting_perftests fails to build due to an attempt to return an rvalue BUG=660541 ========== to ========== Fix remoting_perftests build for ARM While compiling chromium for chromeos, remoting_perftests fails to build due to an attempt to return an rvalue BUG=660541 Committed: https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d Cr-Commit-Position: refs/heads/master@{#433350} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d Cr-Commit-Position: refs/heads/master@{#433350} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
