Fix remoting_perftests build for ARM

Fix remoting_perftests build for ARM

While compiling chromium for chromeos, remoting_perftests fails to
build due to an attempt to return an rvalue

BUG=660541
Committed: https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d
Cr-Commit-Position: refs/heads/master@{#433350}

[cavalcantii1, 2016-11-18 19:47:49]

The CQ bit was checked by cavalcantii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 19:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 19:48:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 19:48:36]

Dry run: The author amaury.leleyzour@arm.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[cavalcantii1, 2016-11-18 22:52:25]

The CQ bit was checked by cavalcantii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 22:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cavalcantii1, 2016-11-18 23:52:05]

cavalcantii@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[commit-bot: I haz the power, 2016-11-18 23:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 23:56:17]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-11-19 00:11:57]

LGTM.
Strange that it fails to compile only for ARM. Do you know why?

[Amaury.LeLeyzour_arm.com, 2016-11-19 00:17:57]

I believe the difference from a different behavior between gcc and clang.
Chromium for chromiumOS uses gcc, while on Linux it uses clang. As for Intel, I
believe it uses clang. No idea for Windows.
Gcc seems to be more restrictive (though totally correct) and inflexible when
dealing with a std::unique_ptr<A> = std::unique_ptr<B> even when A and B are
related.


From: sergeyu@chromium.org [mailto:sergeyu@chromium.org]
Sent: Friday, November 18, 2016 4:12 PM
To: Amaury LeLeyzour; cavalcantii@chromium.org; jamiewalch@chromium.org
Cc: chromium-reviews@chromium.org; chromoting-reviews@chromium.org
Subject: Re: Fix remoting_perftests build for ARM (issue 2515813002 by
amaury.leleyzour@arm.com)

LGTM.
Strange that it fails to compile only for ARM. Do you know why?

https://codereview.chromium.org/2515813002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cavalcantii1, 2016-11-19 00:23:01]

Adding it to the CQ.

[cavalcantii1, 2016-11-19 00:23:04]

The CQ bit was checked by cavalcantii@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:24:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:30:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-19 00:33:28]

Description was changed from

==========
Fix remoting_perftests build for ARM

While compiling chromium for chromeos, remoting_perftests fails to
build due to an attempt to return an rvalue

BUG=660541
==========

to

==========
Fix remoting_perftests build for ARM

While compiling chromium for chromeos, remoting_perftests fails to
build due to an attempt to return an rvalue

BUG=660541

Committed: https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d
Cr-Commit-Position: refs/heads/master@{#433350}
==========

[commit-bot: I haz the power, 2016-11-19 00:33:29]

Patchset 1 (id:??) landed as
https://crrev.com/29bfbecb49572b61264de7acccf8b23942bba43d
Cr-Commit-Position: refs/heads/master@{#433350}