Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2515763003: DevTools: use shorthand syntax in interface definitions. (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
dgozman, alph
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: use shorthand syntax in interface definitions. BUG=659389 TBR=alph Committed: https://crrev.com/fd8e3e1b305c086ce7e6dffdfef1ba1a7dd4cec2 Cr-Commit-Position: refs/heads/master@{#433379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -346 lines) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditCategory.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js View 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/FileUtils.js View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/OutputStream.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Progress.js View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/TextUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAuditCategory.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 3 chunks +45 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/LayerTreeBase.js View 1 chunk +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 3 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ActionRegistry.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Context.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/StaticViewportControl.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 4 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 5 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js View 5 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
pfeldman
4 years, 1 month ago (2016-11-19 01:02:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515763003/1
4 years, 1 month ago (2016-11-19 01:04:56 UTC) #6
alph
lgtm
4 years, 1 month ago (2016-11-19 01:10:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 02:16:09 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 02:18:35 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd8e3e1b305c086ce7e6dffdfef1ba1a7dd4cec2
Cr-Commit-Position: refs/heads/master@{#433379}

Powered by Google App Engine
This is Rietveld 408576698