Issue 2515763002: VM: [Kernel] Don't use Parser::ParseStaticFieldInitializer for fields that come from Kernel.

Issue 2515763002: VM: [Kernel] Don't use Parser::ParseStaticFieldInitializer for fields that come from Kernel. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
4 years, 1 month ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

VM: [Kernel] Don't use Parser::ParseStaticFieldInitializer for fields that come from Kernel. Introduce separate function kernel::ParseStaticFieldInitializer to handle these fields. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/46fcf14475801627070f36c210a4ddcffd3b984d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reduce code duplication #

Patch Set 3 : Done #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -27 lines)			Patch
M	runtime/vm/compiler.cc	View	1	1 chunk	+1 line, -23 lines	0 comments	Download
M	runtime/vm/kernel.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/kernel_reader.cc	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View		1 chunk	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

LGTM https://codereview.chromium.org/2515763002/diff/1/runtime/vm/kernel_reader.cc File runtime/vm/kernel_reader.cc (right): https://codereview.chromium.org/2515763002/diff/1/runtime/vm/kernel_reader.cc#newcode681 runtime/vm/kernel_reader.cc:681: dart::String::Handle(zone, field.name()))); You could use just one String::Handle ...

4 years, 1 month ago (2016-11-18 18:38:15 UTC) #2

Vyacheslav Egorov (Google)

https://codereview.chromium.org/2515763002/diff/1/runtime/vm/kernel_reader.cc File runtime/vm/kernel_reader.cc (right): https://codereview.chromium.org/2515763002/diff/1/runtime/vm/kernel_reader.cc#newcode681 runtime/vm/kernel_reader.cc:681: dart::String::Handle(zone, field.name()))); On 2016/11/18 18:38:15, kustermann wrote: > You ...

4 years, 1 month ago (2016-11-18 18:48:45 UTC) #3

Vyacheslav Egorov (Google)

4 years, 1 month ago (2016-11-21 14:53:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
46fcf14475801627070f36c210a4ddcffd3b984d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages