Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2515723003: [ObjC ARC] Converts ios/chrome/browser/geolocation:unit_tests to ARC.Automatically generated ARCM… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), mac-reviews_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/geolocation:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/01a4673f93245f99b1db2c3a03f02e41f60fdcf8 Cr-Commit-Position: refs/heads/master@{#433564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M ios/chrome/browser/geolocation/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/geolocation/CLLocation+XGeoHeaderTest.mm View 2 chunks +11 lines, -8 lines 0 comments Download
M ios/chrome/browser/geolocation/location_manager_unittest.mm View 4 chunks +7 lines, -3 lines 0 comments Download
M ios/chrome/browser/geolocation/omnibox_geolocation_local_state_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 12:02:10 UTC) #6
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-21 14:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515723003/1
4 years, 1 month ago (2016-11-21 15:39:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 16:44:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:49:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01a4673f93245f99b1db2c3a03f02e41f60fdcf8
Cr-Commit-Position: refs/heads/master@{#433564}

Powered by Google App Engine
This is Rietveld 408576698