third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2515693003: DevTools: bring violations and timeline warnings in sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2515693003: DevTools: bring violations and timeline warnings in sync. (Closed)

Patch Set: idle callback test fixed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index bb5a60dca8f3e513e47ad38979e3c4f51b1e33b6..c98f28029ef7c9e68a45c3c282bb7bd4558f6621 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -1738,6 +1738,12 @@ Timeline.TimelineUIUtils = class {

'Idle callback execution extended beyond deadline by ' +

Number.millisToString(event.duration - eventData['allottedMilliseconds'], true));

break;

+ case warnings.LongHandler:

+ span.textContent = Common.UIString('Handler took %s', Number.millisToString(event.duration, true));

+ break;

+ case warnings.LongRecurringHandler:

+ span.textContent = Common.UIString('Recurring handler took %s', Number.millisToString(event.duration, true));

+ break;

case warnings.V8Deopt:

span.appendChild(UI.createExternalLink(

'https://github.com/GoogleChrome/devtools-docs/issues/53', Common.UIString('Not optimized')));