third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js - Issue 2515693003: DevTools: bring violations and timeline warnings in sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js

Issue 2515693003: DevTools: bring violations and timeline warnings in sync. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js

index 74e2a8a1e7c357594dcef4850b9157e7d89216fc..ca15c783c7912e996298f6bb818b5436b86c583f 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js

@@ -444,8 +444,7 @@ TimelineModel.TimelineFrame = class {

* @return {boolean}

hasWarnings() {

- var /** @const */ longFrameDurationThresholdMs = 22;

- return !this.idle && this.duration > longFrameDurationThresholdMs;

+ return false;

caseq 2016/11/19 05:51:08 This function becomes meaningless in its present f

}

/**