Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2515683002: [builtins] add context input to users of CreateKeyValueArray opcodes (Closed)

Created:
4 years, 1 month ago by caitp
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] add context input to users of CreateKeyValueArray opcode BUG=666622, v8:5388 R=bmeurer@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/e84f0adba9e5a06b15cf319b9c5c78a0fa86c551 Cr-Commit-Position: refs/heads/master@{#41118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M src/compiler/js-builtin-reducer.cc View 2 chunks +6 lines, -4 lines 0 comments Download
A test/mjsunit/es6/regress/regress-666622.js View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
caitp
PTAL
4 years, 1 month ago (2016-11-18 15:30:02 UTC) #3
Benedikt Meurer
LGTM. Thanks!
4 years, 1 month ago (2016-11-18 18:14:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515683002/1
4 years, 1 month ago (2016-11-18 18:14:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:16:56 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:17:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e84f0adba9e5a06b15cf319b9c5c78a0fa86c551
Cr-Commit-Position: refs/heads/master@{#41118}

Powered by Google App Engine
This is Rietveld 408576698