Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2515673002: Fix enrollment crash (Closed)

Created:
4 years, 1 month ago by Thiemo Nagel
Modified:
4 years, 1 month ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix enrollment crash Fix a crash when hitting the "Done" button after enrollment that was introduced in 8d2791ecec5187ab2188b123ce50710d14f9b9e4. BUG=656558 Committed: https://crrev.com/dd095cf6bd65478ad5e09f63aa0d4a927e85fc89 Cr-Commit-Position: refs/heads/master@{#433199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Thiemo Nagel
Could I please get a quick rubber stamp on this one?
4 years, 1 month ago (2016-11-18 14:44:07 UTC) #4
Roman Sorokin (ftl)
lgtm
4 years, 1 month ago (2016-11-18 14:46:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515673002/1
4 years, 1 month ago (2016-11-18 14:49:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 15:14:34 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 15:16:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd095cf6bd65478ad5e09f63aa0d4a927e85fc89
Cr-Commit-Position: refs/heads/master@{#433199}

Powered by Google App Engine
This is Rietveld 408576698