Issue 2515663002: VM: Fix Flutter build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2515663002: VM: Fix Flutter build. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
4 years, 1 month ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra, Cutch

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix Flutter build. libdart_vm_nosnapshot should not include dart_maybe_precompiled_runtime_config. DART_NOSNAPSHOT and DART_PRECOMPILED_RUNTIME are mutually exclusive configurations add a meaningful check in the globals.h to catch this instead of cryptic compile time errors. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/35c828c2d29ead6a7a281e576d4da7b07ab28799

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/platform/globals.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	runtime/vm/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Vyacheslav Egorov (Google)

4 years, 1 month ago (2016-11-18 14:48:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
35c828c2d29ead6a7a281e576d4da7b07ab28799 (presubmit successful).