Fuchsia: Partial implementation of dart:io sockets

Fuchsia: Partial implementation of dart:io sockets

This changes the eventhandler to epoll and adds some code for sockets
to runtime/bin/sockets_fuchsia.cc. It also adds some simple tests
to hello_fuchsia.dart.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/14233482d93b2dd319671b32d962fd4eb63f735f

[zra, 2016-11-18 23:39:50]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2016-11-18 23:42:17]

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia.cc
File runtime/bin/fdutils_fuchsia.cc (right):

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia...
runtime/bin/fdutils_fuchsia.cc:77: int result = NO_RETRY_EXPECTED(ioctl(fd,
FIONREAD, &available));
Here is the ioctl call for Fuchsia.

https://codereview.chromium.org/2515643004/diff/1/runtime/tests/vm/dart/hello...
File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):

https://codereview.chromium.org/2515643004/diff/1/runtime/tests/vm/dart/hello...
runtime/tests/vm/dart/hello_fuchsia_test.dart:208: //
print("testSimpleReadWrite");
Uncommenting this test should trigger a call to the ioctl.

[kulakowski1, 2016-11-18 23:42:38]

On 2016/11/18 23:42:17, zra wrote:
>
https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia.cc
> File runtime/bin/fdutils_fuchsia.cc (right):
> 
>
https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia...
> runtime/bin/fdutils_fuchsia.cc:77: int result = NO_RETRY_EXPECTED(ioctl(fd,
> FIONREAD, &available));
> Here is the ioctl call for Fuchsia.
> 
>
https://codereview.chromium.org/2515643004/diff/1/runtime/tests/vm/dart/hello...
> File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):
> 
>
https://codereview.chromium.org/2515643004/diff/1/runtime/tests/vm/dart/hello...
> runtime/tests/vm/dart/hello_fuchsia_test.dart:208: //
> print("testSimpleReadWrite");
> Uncommenting this test should trigger a call to the ioctl.

Thanks! looking now.

[siva, 2016-11-21 02:22:40]

asiva@google.com changed reviewers:
+ rmacnak@google.com

[siva, 2016-11-21 02:22:41]

lgtm

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/eventhandler_fu...
File runtime/bin/eventhandler_fuchsia.cc (right):

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/eventhandler_fu...
runtime/bin/eventhandler_fuchsia.cc:172: }
timer_fd is not being registered here, do we not have a timer_fd in fuchsia?

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/eventhandler_fu...
runtime/bin/eventhandler_fuchsia.cc:186:
VOID_NO_RETRY_EXPECTED(close(epoll_fd_));
Ditto comment about missing timer_fd_

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia.cc
File runtime/bin/fdutils_fuchsia.cc (right):

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia...
runtime/bin/fdutils_fuchsia.cc:83: #endif
Can this be turned on, as the ioctl change has been checked in I believe.

[siva, 2016-11-21 02:22:42]

lgtm

[zra, 2016-11-21 05:56:24]

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/eventhandler_fu...
File runtime/bin/eventhandler_fuchsia.cc (right):

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/eventhandler_fu...
runtime/bin/eventhandler_fuchsia.cc:172: }
On 2016/11/21 02:22:41, siva wrote:
> timer_fd is not being registered here, do we not have a timer_fd in fuchsia?

AFAIK there are no timerfds in Fuchsia. Timers are implemented using the timeout
argument to epoll_wait().

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/eventhandler_fu...
runtime/bin/eventhandler_fuchsia.cc:186:
VOID_NO_RETRY_EXPECTED(close(epoll_fd_));
On 2016/11/21 02:22:41, siva wrote:
> Ditto comment about missing timer_fd_

Acknowledged.

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia.cc
File runtime/bin/fdutils_fuchsia.cc (right):

https://codereview.chromium.org/2515643004/diff/1/runtime/bin/fdutils_fuchsia...
runtime/bin/fdutils_fuchsia.cc:83: #endif
On 2016/11/21 02:22:41, siva wrote:
> Can this be turned on, as the ioctl change has been checked in I believe.

The change to the syscall needed to support the ioctl  has landed, but it hasn't
been wired up to the ioctl, yet, so I'll leave this commented out.

[zra, 2016-11-21 06:04:18]

Description was changed from

==========
Fuchsia: Partial implementation of dart:io sockets

This changes the eventhandler to epoll and adds some code for sockets
to runtime/bin/sockets_fuchsia.cc. It also adds some simple tests
to hello_fuchsia.dart.
==========

to

==========
Fuchsia: Partial implementation of dart:io sockets

This changes the eventhandler to epoll and adds some code for sockets
to runtime/bin/sockets_fuchsia.cc. It also adds some simple tests
to hello_fuchsia.dart.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/14233482d93b2dd319671b32d962fd4eb63f735f
==========

[zra, 2016-11-21 06:04:20]

Committed patchset #2 (id:20001) manually as
14233482d93b2dd319671b32d962fd4eb63f735f (presubmit successful).