Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2515643003: Flush stdout before shelling out. (Closed)

Created:
4 years, 1 month ago by M-A Ruel
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, ehmaldonado_chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flush stdout before shelling out. Otherwise the output can be intermingled. R=dpranke@chromium.org BUG=666867 Committed: https://crrev.com/f00125f82a0e0ce948644ff239941e6f727984bf Cr-Commit-Position: refs/heads/master@{#433340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/test_env.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
M-A Ruel
4 years, 1 month ago (2016-11-18 20:32:27 UTC) #1
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-18 21:13:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515643003/1
4 years, 1 month ago (2016-11-18 21:23:30 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f00125f82a0e0ce948644ff239941e6f727984bf Cr-Commit-Position: refs/heads/master@{#433340}
4 years, 1 month ago (2016-11-19 00:05:35 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 00:05:37 UTC) #7
Message was sent while issue was closed.
Failed to apply patch for testing/test_env.py:
While running git apply --index -p1;
  error: patch failed: testing/test_env.py:211
  error: testing/test_env.py: patch does not apply

Patch:       testing/test_env.py
Index: testing/test_env.py
diff --git a/testing/test_env.py b/testing/test_env.py
index
7d72169d235d63189df04dcb037c78eb5fa70b9e..2e446e7e5218a33b199aa2ee4aa8c04180e62351
100755
--- a/testing/test_env.py
+++ b/testing/test_env.py
@@ -211,6 +211,7 @@ def run_executable(cmd, env):
         '\n'.join('    %s=%s' %
             (k, v) for k, v in sorted(extra_env.iteritems())),
         ' '.join(cmd)))
+  sys.stdout.flush()
   env.update(extra_env or {})
   try:
     # See above comment regarding offline symbolization.

Powered by Google App Engine
This is Rietveld 408576698