Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2515643002: [heap] ExternalStringTable: Separate Iterate and CleanUp methods (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] ExternalStringTable: Separate Iterate and CleanUp methods This way we can just process new space strings when needed. BUG=chromium:651354 Committed: https://crrev.com/80339771e3355ecfc143ad525f8c9e0ce5fe4b11 Cr-Commit-Position: refs/heads/master@{#41107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M src/heap/heap.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Lippautz
PTAL; this could be useful independent of the minor mc collector
4 years, 1 month ago (2016-11-18 12:01:44 UTC) #2
ulan
lgtm
4 years, 1 month ago (2016-11-18 12:58:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515643002/1
4 years, 1 month ago (2016-11-18 12:59:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 13:01:03 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 13:01:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80339771e3355ecfc143ad525f8c9e0ce5fe4b11
Cr-Commit-Position: refs/heads/master@{#41107}

Powered by Google App Engine
This is Rietveld 408576698