Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2515633002:
Use switch-case for CSS delimiter parsing (Closed)
|
Created:
4 years, 1 month ago by kochi Modified:
4 years, 1 month ago Reviewers:
Timothy Loh CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse switch-case for CSS delimiter parsing
This is style-only change and should not change any logic/behavior.
Committed: https://crrev.com/87c9635abb27e45f913c174043fc115c088aead5
Cr-Commit-Position: refs/heads/master@{#433470}
Patch Set 1 #Patch Set 2 : compiler warning fix. #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by kochi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use switch-case for CSS delimiter parsing This is style-only change and should not change any logic/behavior. ========== to ========== Use switch-case for CSS delimiter parsing This is style-only change and should not change any logic/behavior. ==========
kochi@chromium.org changed reviewers: + timloh@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by kochi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/18 08:21:56, kochi wrote: > PTAL lgtm
The CQ bit was checked by kochi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479694394178850,
"parent_rev": ["4abfe9e3dcb1af50f3c44e23d49f0039321200b3", null], "commit_rev":
["354ab31386b6d84790efb523e1c5b20d4a859a80", null]}
Message was sent while issue was closed.
Description was changed from ========== Use switch-case for CSS delimiter parsing This is style-only change and should not change any logic/behavior. ========== to ========== Use switch-case for CSS delimiter parsing This is style-only change and should not change any logic/behavior. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use switch-case for CSS delimiter parsing This is style-only change and should not change any logic/behavior. ========== to ========== Use switch-case for CSS delimiter parsing This is style-only change and should not change any logic/behavior. Committed: https://crrev.com/87c9635abb27e45f913c174043fc115c088aead5 Cr-Commit-Position: refs/heads/master@{#433470} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/87c9635abb27e45f913c174043fc115c088aead5 Cr-Commit-Position: refs/heads/master@{#433470}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2521043002/ by piman@chromium.org. The reason for reverting is: Suspected cause for fast/forms/relayout-shifts-inner-editor.html failures. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28... https://bugs.chromium.org/p/chromium/issues/detail?id=667403. |
