Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2515623003: Stop OffscreenCanvas resize from changing placeholder attributes (Closed)

Created:
4 years, 1 month ago by Justin Novosad
Modified:
4 years, 1 month ago
Reviewers:
xidachen, xlai (Olivia)
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop OffscreenCanvas resize from changing placeholder attributes For consistency with ImageBitmapRenderingContext, the content width and height attributes of a placeholder canvas should simply have no effect, nor should they reflect the intrinsic size of the canvas. BUG=662498 Committed: https://crrev.com/9f8fc171b9422d8f01047eea6b7cf64955ed5a29 Cr-Commit-Position: refs/heads/master@{#433299}

Patch Set 1 #

Patch Set 2 : better tests + stop throwing when setting width/height on placeholder #

Patch Set 3 : report correct intrinsic size #

Messages

Total messages: 24 (11 generated)
Justin Novosad
4 years, 1 month ago (2016-11-18 15:57:14 UTC) #4
xidachen
On 2016/11/18 15:57:14, Justin Novosad wrote: question: Say that OffscreenCanvas resized to 30*40, and the ...
4 years, 1 month ago (2016-11-18 16:32:31 UTC) #5
xlai (Olivia)
Is this already in the spec? Looks a bit odd to have inconsistent size between ...
4 years, 1 month ago (2016-11-18 16:39:50 UTC) #6
Justin Novosad
On 2016/11/18 16:32:31, xidachen wrote: > On 2016/11/18 15:57:14, Justin Novosad wrote: > > question: ...
4 years, 1 month ago (2016-11-18 17:17:09 UTC) #7
Justin Novosad
On 2016/11/18 16:39:50, xlai (Olivia) wrote: > Is this already in the spec? Looks a ...
4 years, 1 month ago (2016-11-18 17:21:47 UTC) #8
xidachen
On 2016/11/18 17:17:09, Justin Novosad wrote: > On 2016/11/18 16:32:31, xidachen wrote: > > On ...
4 years, 1 month ago (2016-11-18 18:18:04 UTC) #11
Justin Novosad
On 2016/11/18 18:18:04, xidachen wrote: > and I don't think elementSize() handles the placeholder frame ...
4 years, 1 month ago (2016-11-18 18:23:42 UTC) #12
Justin Novosad
New patch
4 years, 1 month ago (2016-11-18 18:43:49 UTC) #14
xidachen
On 2016/11/18 18:43:49, Justin Novosad wrote: > New patch lgtm
4 years, 1 month ago (2016-11-18 18:51:26 UTC) #16
xlai (Olivia)
On 2016/11/18 17:21:47, Justin Novosad wrote: > On 2016/11/18 16:39:50, xlai (Olivia) wrote: > > ...
4 years, 1 month ago (2016-11-18 19:13:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515623003/40001
4 years, 1 month ago (2016-11-18 20:41:59 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-18 21:15:46 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 21:18:24 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f8fc171b9422d8f01047eea6b7cf64955ed5a29
Cr-Commit-Position: refs/heads/master@{#433299}

Powered by Google App Engine
This is Rietveld 408576698