Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Issue 2515613006: [DevTools] Move Memory, SystemInfo and Tethering domains to new generator. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Memory, SystemInfo and Tethering domains to new generator. BUG=664683 TBR=pfeldman Committed: https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd Cr-Commit-Position: refs/heads/master@{#433751}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -298 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.h View 2 chunks +9 lines, -13 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 5 chunks +16 lines, -19 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 2 chunks +3 lines, -7 lines 0 comments Download
M content/browser/devtools/protocol/memory_handler.h View 1 1 chunk +10 lines, -11 lines 0 comments Download
M content/browser/devtools/protocol/memory_handler.cc View 1 3 chunks +16 lines, -17 lines 0 comments Download
M content/browser/devtools/protocol/system_info_handler.h View 1 1 chunk +8 lines, -30 lines 0 comments Download
M content/browser/devtools/protocol/system_info_handler.cc View 1 4 chunks +86 lines, -113 lines 0 comments Download
M content/browser/devtools/protocol/tethering_handler.h View 3 chunks +11 lines, -17 lines 0 comments Download
M content/browser/devtools/protocol/tethering_handler.cc View 8 chunks +61 lines, -67 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 chunk +12 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
dgozman
Could you please take a look?
4 years ago (2016-11-21 18:43:06 UTC) #6
caseq
lgtm https://codereview.chromium.org/2515613006/diff/1/content/browser/devtools/protocol/memory_handler.h File content/browser/devtools/protocol/memory_handler.h (right): https://codereview.chromium.org/2515613006/diff/1/content/browser/devtools/protocol/memory_handler.h#newcode26 content/browser/devtools/protocol/memory_handler.h:26: std::unique_ptr<Memory::Frontend> frontend_; We don't seem to need it, ...
4 years ago (2016-11-21 23:32:33 UTC) #7
dgozman
https://codereview.chromium.org/2515613006/diff/1/content/browser/devtools/protocol/memory_handler.h File content/browser/devtools/protocol/memory_handler.h (right): https://codereview.chromium.org/2515613006/diff/1/content/browser/devtools/protocol/memory_handler.h#newcode26 content/browser/devtools/protocol/memory_handler.h:26: std::unique_ptr<Memory::Frontend> frontend_; On 2016/11/21 23:32:33, caseq wrote: > We ...
4 years ago (2016-11-22 00:53:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515613006/20001
4 years ago (2016-11-22 00:54:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/302425)
4 years ago (2016-11-22 01:11:10 UTC) #12
dgozman
TBR'ing pfeldman for content/browser/BUILD.gn
4 years ago (2016-11-22 01:30:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515613006/20001
4 years ago (2016-11-22 01:31:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-22 02:37:44 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-22 02:39:53 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd
Cr-Commit-Position: refs/heads/master@{#433751}

Powered by Google App Engine
This is Rietveld 408576698