Index: net/quic/core/crypto/quic_crypto_client_config.cc |
diff --git a/net/quic/core/crypto/quic_crypto_client_config.cc b/net/quic/core/crypto/quic_crypto_client_config.cc |
index 81328b0d23ce76e9978c2c7bd24c56378e205fde..b0bb2a356a6f17016027b5cfcfb8acf4b3bccfb0 100644 |
--- a/net/quic/core/crypto/quic_crypto_client_config.cc |
+++ b/net/quic/core/crypto/quic_crypto_client_config.cc |
@@ -485,7 +485,6 @@ void QuicCryptoClientConfig::FillInchoateClientHello( |
QuicErrorCode QuicCryptoClientConfig::FillClientHello( |
const QuicServerId& server_id, |
QuicConnectionId connection_id, |
- const QuicVersion actual_version, |
const QuicVersion preferred_version, |
const CachedState* cached, |
QuicWallTime now, |
@@ -697,17 +696,11 @@ QuicErrorCode QuicCryptoClientConfig::FillClientHello( |
string* subkey_secret = &out_params->initial_subkey_secret; |
- // Only perform key diversification for QUIC versions 33 and later. |
- // TODO(rch): remove the |actual_version| argument to this method when |
- // QUIC_VERSION_32 is removed. |
- CryptoUtils::Diversification diversification = |
- actual_version > QUIC_VERSION_32 ? CryptoUtils::Diversification::Pending() |
- : CryptoUtils::Diversification::Never(); |
- if (!CryptoUtils::DeriveKeys(out_params->initial_premaster_secret, |
- out_params->aead, out_params->client_nonce, |
- out_params->server_nonce, hkdf_input, |
- Perspective::IS_CLIENT, diversification, |
- &out_params->initial_crypters, subkey_secret)) { |
+ if (!CryptoUtils::DeriveKeys( |
+ out_params->initial_premaster_secret, out_params->aead, |
+ out_params->client_nonce, out_params->server_nonce, hkdf_input, |
+ Perspective::IS_CLIENT, CryptoUtils::Diversification::Pending(), |
+ &out_params->initial_crypters, subkey_secret)) { |
*error_details = "Symmetric key setup failed"; |
return QUIC_CRYPTO_SYMMETRIC_KEY_SETUP_FAILED; |
} |