Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2515583002: DevTools: move FileSystemWorkspaceBinding under persistence/ (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move FileSystemWorkspaceBinding under persistence/ This patch moves FileSystemWorkspaceBinding under persistence/ module, as planned before. Ideally, the creation of FileSystemWorkspaceBinding should be moved inside persistence as well; however, tests push back to this change, thus the change hasn't been made. BUG=649837 R=dgozman Committed: https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e Cr-Commit-Position: refs/heads/master@{#433370}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -598 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js View 1 chunk +0 lines, -547 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js View 19 chunks +32 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-18 02:58:40 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-18 19:32:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515583002/1
4 years, 1 month ago (2016-11-18 19:48:33 UTC) #8
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/devtools/front_end/main/Main.js: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-18 20:26:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515583002/20001
4 years, 1 month ago (2016-11-18 23:47:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-19 01:31:38 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:33:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e
Cr-Commit-Position: refs/heads/master@{#433370}

Powered by Google App Engine
This is Rietveld 408576698