Make test filters play nice

base/test/launcher/test_launcher.h

Index: base/test/launcher/test_launcher.h
diff --git a/base/test/launcher/test_launcher.h b/base/test/launcher/test_launcher.h
index 218d8b627a969a8de32d65c9d1f947ee2af39887..b7974c6eb39773725c7a31ec3ac6108288b086a1 100644
--- a/base/test/launcher/test_launcher.h
+++ b/base/test/launcher/test_launcher.h
@@ -181,6 +181,8 @@ class TestLauncher {
   int cycles_;  // Number of remaining test itreations, or -1 for infinite.
 
   // Test filters (empty means no filter).
+  std::vector<std::string> positive_test_filter_gtest_;

[Paweł Hajdan Jr., 2016/11/28 12:56:14]

nit: I'd suggest "flag", "cmdline", or similar suffix.

[katthomas, 2016/11/29 21:38:26]

Acknowledged.

+  std::vector<std::string> positive_test_filter_file_;
   std::vector<std::string> positive_test_filter_;

[Paweł Hajdan Jr., 2016/11/28 12:56:14]

Do we need this old variable? If yes, why?

[katthomas, 2016/11/29 21:38:26]

Yes, it is still used.

   std::vector<std::string> negative_test_filter_;

[Dirk Pranke, 2016/11/29 02:07:15]

Even though you only need a single negative_test_filter_, it might be easier to
follow the code if you had two of them, to mirror the positive filters.

[katthomas, 2016/11/29 21:38:26]

Done.