Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2515573002: Fix painting background for composited table cells in a non-composited row. (Closed)

Created:
4 years, 1 month ago by wkorman
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix painting background for composited table cells in a non-composited row. Use a background specific display item client and the LayoutTableRow's visual rect. BUG=658874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2507893002 Cr-Commit-Position: refs/heads/master@{#432693} (cherry picked from commit 9c8fded973e0422c68dd85f3745b26a0a8d96085) Committed: https://chromium.googlesource.com/chromium/src/+/b4fdf5cba5c295b1702bad390bd999b9f0be0503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1208 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.txt View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.txt View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.txt View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.txt View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.txt View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 3 chunks +23 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 5 chunks +54 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wkorman
4 years, 1 month ago (2016-11-18 02:48:55 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4fdf5cba5c295b1702bad390bd999b9f0be0503.

Powered by Google App Engine
This is Rietveld 408576698