Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 25155003: Fix cue rendering test and include support for left/right alignment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added COMPILE_ASSERT Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index 92047be060160fb2648b8ed768a129920592262e..518de2cd725e6fc61b9bbd49d3745b9b724123a8 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -155,12 +155,13 @@ public:
std::pair<double, double> getCSSPosition() const;
+ CSSValueID getCSSAlignment() const;
int getCSSSize() const;
CSSValueID getCSSWritingDirection() const;
CSSValueID getCSSWritingMode() const;
enum WritingDirection {
- Horizontal,
+ Horizontal = 0,
VerticalGrowingLeft,
VerticalGrowingRight,
NumberOfWritingDirections
@@ -168,9 +169,12 @@ public:
WritingDirection getWritingDirection() const { return m_writingDirection; }
enum CueAlignment {
- Start,
+ Start = 0,
Middle,
- End
+ End,
+ Left,
+ Right,
+ NumberOfAlignments
};
CueAlignment getAlignment() const { return m_cueAlignment; }
@@ -266,9 +270,6 @@ private:
CSSValueID m_displayDirection;
- CSSValueID m_displayWritingModeMap[NumberOfWritingDirections];
- CSSValueID m_displayWritingMode;
-
int m_displaySize;
std::pair<float, float> m_displayPosition;

Powered by Google App Engine
This is Rietveld 408576698