Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html

Issue 25155003: Fix cue rendering test and include support for left/right alignment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added COMPILE_ASSERT Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html
diff --git a/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html b/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html
index 4a30a86f4b1f7cf278e55e96f5f4e42dc9fa9bf5..c87f38a28b0fc83fa6cebf3adc30c127a417ee48 100644
--- a/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html
+++ b/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html
@@ -42,14 +42,13 @@
function seeked()
{
consoleWrite("Active cues: " + testTrack.track.activeCues.length);
-
for (var i = 0; i < testTrack.track.activeCues.length; ++i) {
-
cueDisplayElement = textTrackDisplayElement(video, 'display', i);
consoleWrite("");
consoleWrite("* Cue " + i + " *");
testExpected("cueDisplayElement.innerText", testTrack.track.activeCues[i].text);
+ consoleWrite("Cue alignment (default or as specified): " + testTrack.track.activeCues[i].align);
consoleWrite("Cue left position (percentage): " + Math.round(cueDisplayElement.offsetLeft / cueDisplayContainer.offsetWidth * 100));
consoleWrite("Cue top position (percentage): " + Math.round(cueDisplayElement.offsetTop / cueDisplayContainer.offsetHeight * 100));
@@ -74,14 +73,6 @@
currentTestCase++;
}
- function testInitialContainer()
- {
- consoleWrite("");
- consoleWrite("The track container and the media controls should completely cover the video element");
- testExpected("cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight", true);
- testExpected("cueDisplayContainer.offsetWidth == video.videoWidth", true);
- }
-
function loaded()
{
consoleWrite("Test that TextTrack's cues are rendered correctly when the snap to lines flag is not set.");
@@ -96,7 +87,6 @@
waitForEventOnce('canplaythrough', function() {
cueDisplayContainer = textTrackDisplayElement(video);
- testInitialContainer();
runNextTestCase();
});
}

Powered by Google App Engine
This is Rietveld 408576698