Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 25155003: Fix cue rendering test and include support for left/right alignment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index 92047be060160fb2648b8ed768a129920592262e..e7c8c94b38ae75137e06cacef86984d1d29ddfbf 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -155,6 +155,7 @@ public:
std::pair<double, double> getCSSPosition() const;
+ CSSValueID getCSSAlignment() const;
int getCSSSize() const;
CSSValueID getCSSWritingDirection() const;
CSSValueID getCSSWritingMode() const;
@@ -170,7 +171,10 @@ public:
enum CueAlignment {
Start,
Middle,
- End
+ End,
+ Left,
+ Right,
+ NumberOfAlignments
};
CueAlignment getAlignment() const { return m_cueAlignment; }
@@ -269,6 +273,8 @@ private:
CSSValueID m_displayWritingModeMap[NumberOfWritingDirections];
CSSValueID m_displayWritingMode;
+ CSSValueID m_displayAlignmentMap[NumberOfAlignments];
acolwell GONE FROM CHROMIUM 2013/10/04 17:26:41 nit: You should be able to make this static const
vcarbune.chromium 2013/10/07 09:37:28 Nice catch. Done.
+
int m_displaySize;
std::pair<float, float> m_displayPosition;

Powered by Google App Engine
This is Rietveld 408576698