third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp - Issue 2515493002: Refactor HarfBuzzShaper to not retain font data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

Issue 2515493002: Refactor HarfBuzzShaper to not retain font data (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

index 8029ff20aa19a81a6cb5eb52a5d7ef186acfd95f..80f506bd8c2af2a2cab59a57b309b3199c066441 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

@@ -15,8 +15,8 @@ PassRefPtr<const ShapeResult> CachingWordShapeIterator::shapeWordWithoutSpacing(

if (cacheEntry && cacheEntry->m_shapeResult)

return cacheEntry->m_shapeResult;

- HarfBuzzShaper shaper(font, wordRun);

- RefPtr<const ShapeResult> shapeResult = shaper.shapeResult();

+ HarfBuzzShaper shaper(wordRun);

+ RefPtr<const ShapeResult> shapeResult = shaper.shapeResult(font);

if (!shapeResult)

return nullptr;

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h » ('j') | no next file with comments »