Refactor HarfBuzzShaper to not retain font data

third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef HarfBuzzShaper_h
 #define HarfBuzzShaper_h
 
 #include "platform/fonts/FontDescription.h"
-#include "platform/fonts/SmallCapsIterator.h"
 #include "platform/fonts/shaping/ShapeResult.h"
 #include "platform/geometry/FloatPoint.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/text/TextRun.h"
 #include "wtf/Allocator.h"
 #include "wtf/Deque.h"
 #include "wtf/HashSet.h"
 #include "wtf/Vector.h"
 #include "wtf/text/CharacterNames.h"
 #include <hb.h>
@@ skipping 84 matching lines @@
 //
 // Now this sub run is successfully processed and can be appended to
 // ShapeResult. A new ShapeResult::RunInfo is created. The logic in
 // insertRunIntoShapeResult then takes care of merging the shape result into
 // the right position the vector of RunInfos in ShapeResult.
 //
 // Shaping then continues analogously for the remaining Hiragana Japanese
 // sub-run, and the result is inserted into ShapeResult as well.
 class PLATFORM_EXPORT HarfBuzzShaper final {
  public:
-  HarfBuzzShaper(const Font*, const TextRun&);
-  PassRefPtr<ShapeResult> shapeResult();
+  HarfBuzzShaper(const TextRun&);
+  PassRefPtr<ShapeResult> shapeResult(const Font*);
   ~HarfBuzzShaper() {}
 
   enum HolesQueueItemAction { HolesQueueNextFont, HolesQueueRange };
 
   struct HolesQueueItem {
     DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
     HolesQueueItemAction m_action;
     unsigned m_startIndex;
     unsigned m_numCharacters;
     HolesQueueItem(HolesQueueItemAction action, unsigned start, unsigned num)
         : m_action(action), m_startIndex(start), m_numCharacters(num){};
   };
 
- protected:
   using FeaturesVector = Vector<hb_feature_t, 6>;
 
-  class CapsFeatureSettingsScopedOverlay final {
-    STACK_ALLOCATED()
-
-   public:
-    CapsFeatureSettingsScopedOverlay(FeaturesVector&,
-                                     FontDescription::FontVariantCaps);
-    CapsFeatureSettingsScopedOverlay() = delete;
-    ~CapsFeatureSettingsScopedOverlay();
-
-   private:
-    void overlayCapsFeatures(FontDescription::FontVariantCaps);
-    void prependCounting(const hb_feature_t&);
-    FeaturesVector& m_features;
-    size_t m_countFeatures;
-  };
-
  private:
-  void setFontFeatures();
-
-  void appendToHolesQueue(HolesQueueItemAction,
-                          unsigned startIndex,
-                          unsigned numCharacters);
-  void prependHolesQueue(HolesQueueItemAction,
-                         unsigned startIndex,
-                         unsigned numCharacters);
-  void splitUntilNextCaseChange(HolesQueueItem& currentQueueItem,
-                                SmallCapsIterator::SmallCapsBehavior&);
-  inline bool shapeRange(hb_buffer_t* harfBuzzBuffer,
-                         const SimpleFontData* currentFont,
-                         PassRefPtr<UnicodeRangeSet> currentFontRangeSet,
-                         UScriptCode currentRunScript,
+  inline bool shapeRange(hb_buffer_t*,
+                         const Font*,
+                         const FeaturesVector&,
+                         const SimpleFontData*,
+                         PassRefPtr<UnicodeRangeSet>,
+                         UScriptCode,
                          hb_language_t);
-  bool extractShapeResults(hb_buffer_t* harfBuzzBuffer,
+  bool extractShapeResults(hb_buffer_t*,
                            ShapeResult*,
                            bool& fontCycleQueued,
-                           const HolesQueueItem& currentQueueItem,
-                           const SimpleFontData* currentFont,
-                           UScriptCode currentRunScript,
+                           Deque<HolesQueueItem>*,
+                           const HolesQueueItem&,
+                           const Font*,
+                           const SimpleFontData*,
+                           UScriptCode,
                            bool isLastResort);
-  bool collectFallbackHintChars(Vector<UChar32>& hint);
+  bool collectFallbackHintChars(const Deque<HolesQueueItem>&,
+                                Vector<UChar32>& hint);
 
   void insertRunIntoShapeResult(
       ShapeResult*,
       std::unique_ptr<ShapeResult::RunInfo> runToInsert,
       unsigned startGlyph,
       unsigned numGlyphs,
       hb_buffer_t*);
 
-  const Font* m_font;
   const TextRun& m_textRun;
-
   std::unique_ptr<UChar[]> m_normalizedBuffer;
   unsigned m_normalizedBufferLength;
-
-  FeaturesVector m_features;
-  Deque<HolesQueueItem> m_holesQueue;
 };
 
 }  // namespace blink
 
 #endif  // HarfBuzzShaper_h