Move const PortName data out of header file

Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class (see
crrev.com/2512753002) seems like overkill and doesn't seem to help.

BUG=630755
Committed: https://crrev.com/facf44181190ded72c43ce0813ccd0aae56d78f2
Cr-Commit-Position: refs/heads/master@{#433727}

[brucedawson, 2016-11-17 17:25:36]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 17:26:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-11-17 18:14:31]

brucedawson@chromium.org changed reviewers:
+ rockot@chromium.org

[brucedawson, 2016-11-17 18:14:31]

Minor optimization - PTAL

[Ken Rockot(use gerrit already), 2016-11-17 18:15:32]

LGTM, thanks!

[commit-bot: I haz the power, 2016-11-17 18:49:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:49:06]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-11-21 23:13:40]

On 2016/11/17 18:15:32, Ken Rockot wrote:
> LGTM, thanks!

crrev.com/2512753002 is a theoretically better solution, but it doesn't actually
give better results and it is more complicated. I am linking to it from here for
completeness. I will land this change now.

[brucedawson, 2016-11-21 23:14:10]

Description was changed from

==========
Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class seems like
overkill.

BUG=630755
==========

to

==========
Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class (see
crrev.com/2512753002) seems like overkill and doesn't seem to help.

BUG=630755
==========

[brucedawson, 2016-11-21 23:14:18]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:14:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:14:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479770058535160, "parent_rev":
"ec5c77de9653eb19a1cf389e1c5a911beec709b5", "commit_rev":
"4b363f3ad54580ee35b4bb21434e7dd1b9d1fe2d"}

[commit-bot: I haz the power, 2016-11-22 01:15:02]

Description was changed from

==========
Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class (see
crrev.com/2512753002) seems like overkill and doesn't seem to help.

BUG=630755
==========

to

==========
Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class (see
crrev.com/2512753002) seems like overkill and doesn't seem to help.

BUG=630755
==========

[commit-bot: I haz the power, 2016-11-22 01:15:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-22 01:21:16]

Description was changed from

==========
Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class (see
crrev.com/2512753002) seems like overkill and doesn't seem to help.

BUG=630755
==========

to

==========
Move const PortName data out of header file

When non-integral const data is defined in a header file it often ends
up being instantiated in multiple translation units. It also ends up in
the read/write data segment which means it isn't shared between
processes. This change has the following affect on the size of sections
in a 32-bit release Windows build:

chrome.dll
     .text:   144 bytes change
    .rdata:   -32 bytes change
     .data:  -736 bytes change
    .reloc:   140 bytes change
Total change:  -484 bytes

chrome_child.dll
     .text:    32 bytes change
    .rdata:  -112 bytes change
     .data:  -736 bytes change
    .reloc:   -84 bytes change
Total change:  -900 bytes

Note that the sections that increase in size are either shareable
(.text) or discardable (.reloc).

I wish I could use "extern constexpr" to ensure that no constructors are
run, but C++ does not allow that. inline constexpr is not yet supported,
and making the variables a static constexpr member of a class (see
crrev.com/2512753002) seems like overkill and doesn't seem to help.

BUG=630755

Committed: https://crrev.com/facf44181190ded72c43ce0813ccd0aae56d78f2
Cr-Commit-Position: refs/heads/master@{#433727}
==========

[commit-bot: I haz the power, 2016-11-22 01:21:17]

Patchset 1 (id:??) landed as
https://crrev.com/facf44181190ded72c43ce0813ccd0aae56d78f2
Cr-Commit-Position: refs/heads/master@{#433727}