Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2515463002: Move the IFWL_Edit Events out of ifwl_edit.h (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move the IFWL_Edit Events out of ifwl_edit.h This Cl moves the edit events to actual class files and renames to drop the Edt from the names. Committed: https://pdfium.googlesource.com/pdfium/+/098f454bddc57c9af00d725132a6d9ad8bdb171f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -87 lines) Patch
M BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtcheckword.h View 1 chunk +8 lines, -7 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtcheckword.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evttextchanged.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evttextchanged.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/fwl/core/cfwl_evttextfull.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/fwl/core/cfwl_evttextfull.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtvalidate.h View 1 chunk +9 lines, -7 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtvalidate.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 1 chunk +0 lines, -26 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 6 chunks +14 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 4 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-17 16:08:44 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-17 17:08:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515463002/1
4 years, 1 month ago (2016-11-17 17:24:49 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 17:25:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/098f454bddc57c9af00d725132a6d9ad8bdb...

Powered by Google App Engine
This is Rietveld 408576698