Unified Gesture Recognizer

ui/events/gesture_detection/filtered_gesture_provider.h

Index: ui/events/gesture_detection/filtered_gesture_provider.h
diff --git a/ui/events/gesture_detection/filtered_gesture_provider.h b/ui/events/gesture_detection/filtered_gesture_provider.h
index 4d63be64a8323fff17f71dc58538a66461fec969..c26350c70cd38c2c4d187ae4bcba3a8ae5b0f4ac 100644
--- a/ui/events/gesture_detection/filtered_gesture_provider.h
+++ b/ui/events/gesture_detection/filtered_gesture_provider.h
@@ -16,7 +16,7 @@ namespace ui {
 // events and touch event acks.
 class GESTURE_DETECTION_EXPORT FilteredGestureProvider
     : public ui::TouchDispositionGestureFilterClient,
-      public ui::GestureProviderClient {
+      private ui::GestureProviderClient {

[jdduke (slow), 2014/05/02 17:56:43]

Was this intentional? I usually take private inheritance to mean "has-a" or
"implemented in terms of", and I'm not sure how that applies here?

[jdduke (slow), 2014/05/02 17:58:42]

I see, you did use it in that way... I'd really prefer we compose rather than
inherit from FilteredGestureProvider, if possible.

[tdresser, 2014/05/05 15:42:35]

Yup, this is broken, we do want an "is-a" relationship, as we pass the
FilteredGestureProvider to the GestureProvider as a GestureProviderClient.

Fixed.

  public:
   // |client| will be offered all gestures detected by the |gesture_provider_|
   // and allowed by the |gesture_filter_|.