Issue 25154003: valueForBorderRadiusShorthand returns wrong values in some case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25154003: valueForBorderRadiusShorthand returns wrong values in some case. (Closed)

Created:
7 years, 2 months ago by tasak

Modified:
7 years, 2 months ago

Reviewers:
hayato, eae, eseidel

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

valueForBorderRadiusShorthand returns wrong values in some case. Because valueForBorderRadiusShorthand misses the followings: - showHorizontalBottomRight depends on showHorizontalBottomLeft. - showHorizontalTopRight depends on showHorizontalBottomRight (including showHorizontalBottomLeft). c.f. http://dev.w3.org/csswg/css-backgrounds/#the-border-radius BUG=298972 TEST=fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158787

Patch Set 1 #

Patch Set 2 : Fixed border-radius-interpolation.html #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -4 lines)			Patch
A	LayoutTests/fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/getComputedStyle/getComputedStyle-borderRadius-2-expected.txt	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/25154003/5001

7 years, 2 months ago (2013-10-03 02:03:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/25154003/5001

7 years, 2 months ago (2013-10-03 05:39:16 UTC) #5

Message was sent while issue was closed.

Change committed as 158787

Expand Messages | Collapse Messages